fix(js-legacy): decode the correct signers in WithdrawWithheldTokensFromAccounts - #1377
Open
latent-9 wants to merge 1 commit into
Open
fix(js-legacy): decode the correct signers in WithdrawWithheldTokensFromAccounts#1377latent-9 wants to merge 1 commit into
latent-9 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
decodeWithdrawWithheldTokensFromAccountsInstructionreturns the wrongsignersaccounts. With no multisig signers it reports the source accounts as signers, and with multisig signers it truncates them to the number of sources.Why
The decoder sizes the
signersslice withnumTokenAccounts, which the encoder sets tosources.length:createWithdrawWithheldTokensFromAccountsInstructionlays out the keys as[mint, destination, authority, ...signers, ...sources](it callsaddSigners, then pushes the sources) and encodesnumTokenAccounts = sources.length. So the signers run from index3up tokeys.length - numTokenAccounts, not3 + numTokenAccounts. The two only coincide when the signer count equals the source count.With 2 source accounts:
signersdecodes as the 2 source accounts instead of[].signersdecodes as the first 2, dropping the third.Change
signersup tokeys.length - numTokenAccountsso it covers exactly the multisig signers.Verification
Ran in
clients/js-legacy:pnpm run build,pnpm run lint,pnpm run format, andmocha test/unitall pass. The new tests fail on the current code and pass with the fix.