Add reset signal traps#6
Open
samuel-williams-shopify wants to merge 1 commit into
Open
Conversation
samuel-williams-shopify
force-pushed
the
add-reset-traps
branch
3 times, most recently
from
8e7b2e2 to
33932f9
Compare
samuel-williams-shopify
force-pushed
the
add-reset-traps
branch
from
33932f9 to
0d3cab2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds
Async::Signals::Reset.trap, an explicit process-level reset policy for signal traps restored byAsync::Signals.reset!. The controller now clears inherited registrations while applying configured reset traps, including afterfork, and falls back to the previously captured trap for signals without reset policy.It also adds
async/signals/graceful, which registers reset traps forSIGINTandSIGTERMthat raiseInterrupton the main thread. This lets forked children keep graceful termination behavior without inheriting the parent controller's signal subscriptions.Validation
/Users/samuel/.local/state/tec/toolchain/base_profile/bin/bundle exec sus/Users/samuel/.local/state/tec/toolchain/base_profile/bin/bundle exec rubocop -ACOVERAGE=PartialSummary /Users/samuel/.local/state/tec/toolchain/base_profile/bin/bundle exec sus && /Users/samuel/.local/state/tec/toolchain/base_profile/bin/bundle exec bake covered:validate --paths .covered.db/Users/samuel/.local/state/tec/toolchain/base_profile/bin/bundle exec bake decode:index:coverage lib