Skip to content

Fix misleading error messages with {capture} #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ichaykin wants to merge 3 commits into
base: master
Choose a base branch
from
+37 −2
Open

Fix misleading error messages with {capture} #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b9dca3
Fix misleading error messages with {capture}
ichaykin Jun 19, 2026
685fae9
Adjusted Smarty render exception propagation.
ichaykin Jun 24, 2026
3d848e3
Added tests for exceptions inside capture and for correct exception h…
Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/Template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ private function render($no_output_filter = true, $display = null) {
call_user_func($callback, $this);
}

$renderException = null;
try {

Comment thread
ichaykin marked this conversation as resolved.
// read from cache or render
Expand All @@ -180,9 +181,18 @@ private function render($no_output_filter = true, $display = null) {
$this->getCompiled()->render($this);
}

} catch (\Throwable $e) {
$renderException = $e;
throw $renderException;
} finally {
foreach ($this->endRenderCallbacks as $callback) {
call_user_func($callback, $this);
try {
foreach ($this->endRenderCallbacks as $callback) {
call_user_func($callback, $this);
}
} catch (\Throwable $callbackException) {
if ($renderException === null) {
throw $callbackException;
}
}
}

Expand Down
25 changes: 25 additions & 0 deletions tests/UnitTests/TemplateSource/TagTests/Capture/CompileCaptureTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,31 @@ public function testCapture10()
$this->assertStringContainsString('uppercase', $result);
}

public function testRenderExceptionInsideCaptureIsNotMaskedByEndRenderException()
{
$this->smarty->registerPlugin(\Smarty\Smarty::PLUGIN_FUNCTION, 'capture_fail', function () {
throw new \RuntimeException('render failure inside capture');
});

$this->expectException(\RuntimeException::class);
$this->expectExceptionMessage('render failure inside capture');

$this->smarty->fetch('string:{capture}{capture_fail}{/capture}');
}

public function testEndRenderCallbackExceptionIsThrownWhenRenderSucceeds()
{
$template = $this->smarty->createTemplate('string:render succeeds');
$template->endRenderCallbacks[] = function () {
throw new \RuntimeException('end render callback failure');
};

$this->expectException(\RuntimeException::class);
$this->expectExceptionMessage('end render callback failure');

$template->fetch();
}

/**
* Test spacings
*
Expand Down