cleanup consensus cap

[cedric-cordenier]

Requires

Supports

[github-actions]

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (1)

package github (1)

• com/smartcontractkit/chainlink-common/pkg/capabilities/consensus/ocr3 — 🗑️ Removed

---

📄 View full apidiff report

[Copilot]

Pull request overview

This PR removes the concrete OCR3 consensus capability implementation from pkg/capabilities/consensus/ocr3 and updates the generic requests Store/Handler tests to use local test-only request/response fixtures, avoiding a dependency on the OCR3 package.

Changes:

• Replace ocr3.ReportRequest/ReportResponse usage in requests tests with testReportRequest/testReportResponse fixtures.
• Move/adjust test fixtures into the requests_test package for isolated testing of the generic Store/Handler APIs.
• Delete the OCR3 consensus capability implementation files and associated tests/fixtures under pkg/capabilities/consensus/ocr3.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/capabilities/consensus/requests/store_test.go	Update Store tests to use local testReportRequest fixture types.
pkg/capabilities/consensus/requests/store_stats_test.go	Update stats collector Store test to use testReportRequest.
pkg/capabilities/consensus/requests/handler_test.go	Update Handler tests to use testReportRequest/testReportResponse.
pkg/capabilities/consensus/requests/fixtures_test.go	Introduce testReportRequest/testReportResponse fixtures in requests_test.
pkg/capabilities/consensus/ocr3/value_map_encoder.go	Delete OCR3 encoder implementation.
pkg/capabilities/consensus/ocr3/value_map_encoder_test.go	Delete OCR3 encoder tests.
pkg/capabilities/consensus/ocr3/validation_service.go	Delete OCR3 validation service stub.
pkg/capabilities/consensus/ocr3/transmitter.go	Delete OCR3 contract transmitter implementation.
pkg/capabilities/consensus/ocr3/transmitter_test.go	Delete OCR3 transmitter tests.
pkg/capabilities/consensus/ocr3/testdata/fixtures/capability/test.yaml	Remove OCR3 capability fixture.
pkg/capabilities/consensus/ocr3/testdata/fixtures/capability/schema.json	Remove OCR3 capability schema fixture.
pkg/capabilities/consensus/ocr3/reporting_plugin.go	Delete OCR3 reporting plugin implementation.
pkg/capabilities/consensus/ocr3/reporting_plugin_test.go	Delete OCR3 reporting plugin tests.
pkg/capabilities/consensus/ocr3/ocr3.go	Delete OCR3 capability entrypoint/provider implementation.
pkg/capabilities/consensus/ocr3/ocr3_test.go	Delete OCR3 provider tests.
pkg/capabilities/consensus/ocr3/models.go	Delete OCR3 config/input model types.
pkg/capabilities/consensus/ocr3/factory.go	Delete OCR3 reporting plugin factory.
pkg/capabilities/consensus/ocr3/capability.go	Delete OCR3 executable capability implementation.
pkg/capabilities/consensus/ocr3/capability_test.go	Delete OCR3 capability tests.
pkg/capabilities/consensus/ocr3/benchmark_test.go	Delete OCR3 benchmarks.
pkg/capabilities/consensus/ocr3/batching.go	Delete OCR3 batching/size-calculation helpers.
pkg/capabilities/consensus/ocr3/batching_test.go	Delete OCR3 batching tests.

Suppressed comments (1)

pkg/capabilities/consensus/requests/fixtures_test.go:64

• Copy() dereferences Observations and OverriddenEncoderConfig without nil checks. Several tests construct testReportRequest without setting one or both fields (e.g. store tests that only set WorkflowExecutionID/ExpiresAt), so calling Store.Get/FirstN/All will panic when Copy() runs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.