swr text layout: divide instead of counting lines one by one - #12952
Open
tronical wants to merge 1 commit into
Open
swr text layout: divide instead of counting lines one by one#12952tronical wants to merge 1 commit into
tronical wants to merge 1 commit into
Conversation
max_lines_that_fit added up line heights in a loop because TextShaper::Length had no length by length division: euclid's Length / Length gives a Scale, not a number. Add a small LengthDiv trait for that, with impls for f32, i16 and any euclid Length whose primitive implements it, and do a single division.
tronical
enabled auto-merge (rebase)
August 19, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_lines_that_fit added up line heights in a loop because TextShaper::Length had no length by length division: euclid's Length / Length gives a Scale, not a number. Add a small LengthDiv trait for that, with impls for f32, i16 and any euclid Length whose primitive implements it, and do a single division.