-
Notifications
You must be signed in to change notification settings - Fork 961
Interfaces errors emit better notes #12772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0x6e
wants to merge
17
commits into
master
Choose a base branch
from
nathan/interface-notes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+447
−229
Open
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8422467
compiler: `validate_interface_member_implementation` doesn't generate…
0x6e d0f44c2
compiler: add `property_declaration_node` to find inherited declarations
0x6e 4a7a66e
compiler: validate_interface_member_implementation now adds notes on …
0x6e d9cae48
compiler: add interfaces::validate_interface_implementation
0x6e 6ba7c0c
compiler: interface::apply_child_implement_statements adds notes for …
0x6e 7c2a33c
compiler: emit notes when a declaration conflicts with a child-implem…
0x6e 291e631
compiler: apply_child_implement_statements emits more specific notes
0x6e 36ad0ba
compiler: refactor syntax_for_declaration from syntax for
0x6e 473357d
compiler: interfaces::property_matches_interface uses full syntax for…
0x6e 1d74024
compiler: Display for Function doesn't print void return types
0x6e 63461e9
compiler: interfaces::syntax_for re-uses the Display implementation f…
0x6e c4e3a04
Display for langtype::Function uses named variables inside the format…
0x6e 00cc250
compiler: remove static keyword list from interfaces.rs
0x6e 6d7e7cf
compiler: remove `check_property_declaration_conflicts` from `validat…
0x6e 9f4663d
interfaces: add syntax tests which conflict with builtin components
0x6e d58d875
compiler: interfaces use the non-normalised child id in diagnostic me…
0x6e b2cf74d
compiler: improve interface diagnostic note phrasing
0x6e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.