fix(skyrim-platform): skip DoReset3D when actor 3D is not loaded#2761
Open
jota2rz wants to merge 1 commit into
Open
fix(skyrim-platform): skip DoReset3D when actor 3D is not loaded#2761jota2rz wants to merge 1 commit into
jota2rz wants to merge 1 commit into
Conversation
Prevents crash in FaceGen TRI loading when queueNiNodeUpdate is called on actors whose 3D skeleton hasn't fully loaded yet. This caused an access violation at an invalid address when the face gen system tried to operate on uninitialized data. - Add is3DLoaded() guard before queueNiNodeUpdate in formView.ts - Add GetCurrent3D() null check in CallNative.cpp before DoReset3D
Collaborator
|
Thanks! Added this to the staging branch for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents crash in FaceGen TRI loading when queueNiNodeUpdate is called on actors whose 3D skeleton hasn't fully loaded yet. This caused an access violation at an invalid address when the face gen system tried to operate on not yet loaded character.