add system sites e2e tests - #2429
Conversation
fgiorgetti
left a comment
fgiorgetti
left a comment
There was a problem hiding this comment.
It is working fine. I have added a couple of comments related to the image option for some of the module invocations, but I believe we should raise a separate issue to handle that, as it seems to affect all e2e tests.
…release build as well.
| name: Running E2E Tests | ||
| command: | | ||
| set -x | ||
| export SKUPPER_SYSTEM_CONTROLLER_IMAGE="quay.io/skupper/cli:<< parameters.image_tag >>" |
There was a problem hiding this comment.
Env var is correct, but the image is wrong.
c-kruse
left a comment
c-kruse
left a comment
There was a problem hiding this comment.
Hi! Sorry for the late entry to the review.
I think this is going to pull the latest v2-dev images (and break on a new release tag.)
One thing we had to take some special care to make work with the kube e2e tests was using the local build images instead of pulling them from quay. As I understand it, there isn't a way to compel skupper system sites to not --pull always like there is with the kube control plane.
Open to other ideas, but I think that leaves us with the choice of developing a system site image pull policy mechanism (larger than just this PR) or adding a local registry to our CI jobs so that we can push the images for the e2e tests to pull.
3 participants
e2e tests that implement the Hello World example in system sites (with manual reload).