Fix VectorContinuousCallback affect! for DifferentialEquations v8 - #10
Merged
Merged
Conversation
DiffEq v8 changed the affect! signature for VectorContinuousCallback:
ix is now a Vector{Int8} of event flags rather than a scalar event index.
Use findfirst(!iszero, ix) to extract the scalar index, with a fallback
for older API versions that still pass a scalar.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
affect!callback signature forVectorContinuousCallback:ixis now aVector{Int8}of per-event flags (1 = fired, 0 = not) rather than a scalar integer index of the single event that fired.affect!in_compute_exact_fillwas assigningixdirectly intocondition_reached(aVector{Int64}), causing aMethodError: Cannot convert Vector{Int8} to Int64.findfirst(!iszero, ix)to extract the scalar index from the flag vector, with anisaguard to stay compatible with older DiffEq versions that pass a scalar.Test plan
fill_sequenceagainst the debug dataset — previously crashed, now completes successfullycondition_reachedcorrectly captures event 1 (full), 2 (empty), or 3 (stagnation) in all cases🤖 Generated with Claude Code