Conversation
The livehtml target passed $(0), which Make expands to an empty string, so options given as `make livehtml O="--port 9000"` were silently dropped. The catch-all target above it uses $(O). Also updates SPHINXPROJ, which still held the sqlite-utils value this Makefile was originally copied from.
anandfresh
approved these changes
Sep 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
livehtmltarget indocs/Makefilepasses$(0)where every other target passes$(O). Make expands$(0)to an empty string, so options given the documented Sphinx way are silently dropped:With the fix:
just docspasses the port throughSPHINXOPTS, so it behaves the same before and after.This also updates
SPHINXPROJ, which still held thesqlite-utilsvalue this Makefile was originally copied from. It is unused by the current Sphinx Makefile, but the stale name is confusing next toproject = "LLM"inconf.py.