Show the dismiss X for facets applied as ?column__exact=value - #2869
Open
cycsmail wants to merge 1 commit into
Open
Show the dismiss X for facets applied as ?column__exact=value#2869cycsmail wants to merge 1 commit into
cycsmail wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2011.
The filter form always redirects to
?column__exact=value(filters_should_redirectdefaults the op toexact), butColumnFacetonly looked for?column=valuewhen deciding if a facet value was selected, so a facet applied that way rendered as a plain link with no X to remove it. That matches the screenshot on the issue:Sole Sourcewas applied by clicking the facet, so it gets an X, whileContract Typecame from the filter form and doesn't. The spaces and punctuation in the value turned out to be a red herring.Facet values now match either form of the querystring, and the toggle link removes whichever key is actually in the URL. One thing I left alone: when a
__exactfilter is present, the links for the other values in that facet still append?column=valuenext to it, same as before this change.Added a regression test, the 19 tests in
tests/test_facets.pypass.