Repository navigation
Preserve IDs during the nullable-field migration - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves the people/events autoincrement high-water marks during migration 0061, including when the highest ID was deleted. Rebuilding a table otherwise resets its counter to the largest surviving ID and can reuse deleted identifiers.
Captured this before running the production migration. No production data has been migrated yet. Adds regression coverage for deleted high IDs and verifies the next person ID advances beyond the old counter.
Validation: focused migration test, lint and build pass. Replaying against the production snapshot preserves people sequence 2332 and event sequence 284, with SQLite integrity_check returning ok.