Repository navigation
Conversation
This was referenced Sep 10, 2026
Member
|
there is another PR already under review for progressive list, if you'd like to do no_std please do just that in this PR |
dharjeezy
force-pushed
the
no-std-and-progressive-list
branch
from
September 10, 2026 13:54
88e4a54 to
cfb1ffa
Compare
Author
|
Thanks, dropped it. This is now just the no_std change, and I have rebased so #84 stands on its own for EIP-7916. |
dharjeezy
force-pushed
the
no-std-and-progressive-list
branch
from
September 11, 2026 09:27
cfb1ffa to
3a874ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds
no_stdsupport. Nothing else.This originally also added a
ProgressiveList. That is dropped: #84 already covers EIP-7916 and is further along, so there is no sense in a competing type. This PR is now just the no_std work, as requested.Why
Substrate runtimes compile to
wasm32-unknown-unknownwithoutstd. The containers here need onlycoreandalloc.Changes
#![cfg_attr(not(feature = "std"), no_std)]withextern crate allocstdimports replaced withallocequivalentsstdfeature wires through to the dependencies that need itThe
stdbuild is unchanged.Why it cannot build yet
It depends on no_std versions of
tree_hash,ethereum_sszandethereum_serde_utils, proposed in the PRs above and not yet released.Verification
Verified locally against the proposed branches via path patches.
cargo testcargo check --no-default-features --features sha2 --target wasm32-unknown-unknowncargo fmt --checkThe branch name is left as it was so the existing review thread is preserved, and no longer describes the contents.