fix: resend active WHOAREYOU challenge - #309
Open
mattsse wants to merge 2 commits into
Open
Conversation
Member
|
The clippy errors will be fixed by #310 |
Member
|
Note that the current spec says to respond with a new WHOAREYOU challenge. go-ethereum has re-sent the existing challenge since ethereum/go-ethereum#31356, and I have filed ethereum/devp2p#278 to update the spec accordingly. |
jxs
reviewed
Aug 10, 2026
| challenge.header.kind, | ||
| PacketKind::WhoAreYou { .. } | ||
| )); | ||
| assert_eq!(challenge.header.message_nonce, first_nonce); |
Member
There was a problem hiding this comment.
since we're here we might as well confirm the id_nonce in the WHOAREYOU header matches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resends the currently active WHOAREYOU packet when another ordinary packet arrives from the same node and endpoint during an unfinished handshake.
This preserves the original request nonce and challenge data instead of dropping the retry or creating another outstanding challenge. It also adds a regression test for the geth/Hive
HandshakeResendflow.