Repository navigation
fix(awards-list): use absolute slugs for award project links - #483
Merged
Merged
Conversation
Storyblok's full_slug has no leading slash, so award links resolved relative to the current path (e.g. /services/projects/hey-harper → 404). Normalise through sanitizeSlug, and in drawer.open() so the drawer's expand link is absolute too.
There was a problem hiding this comment.
🔵 Needs a closer look
The license guidance conflicts with the checked-in AGPL terms, and the PostHog environment variable naming is inconsistent.
Pull request overview
Fixes award project links by normalizing Storyblok slugs and makes drawer URLs absolute.
Changes:
- Applies
sanitizeSlugto award links and drawer URLs. - Switches PostHog host configuration to dynamic public environment access.
- Updates license guidance in the README.
File summaries
| File | Description |
|---|---|
src/routes/+layout.svelte |
Uses dynamic PostHog host configuration. |
src/lib/stores/drawer.ts |
Normalizes drawer slugs. |
src/components/proposals/proposal-awards.svelte |
Normalizes proposal award links. |
src/components/blocks/awards-list.svelte |
Generates absolute award project links. |
README.md |
Revises licensing guidance. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (browser) { | ||
| posthog.init(PUBLIC_POSTHOG_PROJECT_TOKEN, { | ||
| api_host: PUBLIC_POSTHOG_POSTHOG_API_HOST || 'https://eu.posthog.com', | ||
| api_host: env.PUBLIC_POSTHOG_POSTHOG_API_HOST || 'https://eu.posthog.com', |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storyblok's full_slug has no leading slash, so award links resolved relative to the current path (e.g. /services/projects/hey-harper → 404). Normalise through sanitizeSlug, and in drawer.open() so the drawer's expand link is absolute too.