Skip to content

refactor(antigravity): drop the orca-status named hook - #2554

Merged
shunkakinoki merged 1 commit into
mainfrom
antigravity-drop-orca-hook
Aug 28, 2026
Merged

refactor(antigravity): drop the orca-status named hook#2554
shunkakinoki merged 1 commit into
mainfrom
antigravity-drop-orca-hook

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Follow-up to #2553. Drops orca-status from the managed Antigravity hooks, leaving moshi-hook and traces-share-to-traces.

Because activate.sh replaces ~/.gemini/config/hooks.json rather than merging into it, removing the entry here also removes it from the live file on the next switch. If orca reinstalls its hook, the following switch reverts it again.

spec/antigravity_config_spec.sh is updated to match: the managed-set assertion drops orca-status, and the revert test now seeds an orca-status entry and asserts activation removes it.

make shell-test passes (2403 examples, 0 failures).


Summary by cubic

Drops the orca-status named hook from the managed Antigravity hooks, leaving moshi-hook and traces-share-to-traces. Because activate.sh replaces ~/.gemini/config/hooks.json instead of merging, the next activation also removes orca-status from the live config; if orca reinstalls its hook, the following activation removes it again.

Refactors

  • Updates the spec's managed-set assertion to drop orca-status and seeds an orca-status entry in the revert test to verify activation removes it.

Written for commit d8a19b4. Summary will update on new commits.

Review in cubic

@pullfrog

pullfrog Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

the model provider had a temporary upstream failure.

The provider refused or dropped the request mid-run — nothing in your repo or your credentials is at fault. Re-trigger Pullfrog; if it keeps happening, check the provider's status page.

provider error: {"code":504,"message":"The operation was aborted","metadata":{"error_type":"timeout"}}

Pullfrog  | Rerun failed job ➔View workflow run | via Pullfrog | Using openrouter/openrouter/free𝕏

@indent

indent Bot commented Aug 27, 2026

Copy link
Copy Markdown

Issues

Review closed.

CI Checks

5 CI checks failed on d8a19b4.

Failing nix-check
  • nix-check finished with failure.
Failing nix-flake
  • nix-flake finished with failure.
Failing nix-format
  • nix-format finished with failure.
Failing nix-test
  • nix-test finished with failure.
Failing pullfrog
  • pullfrog finished with failure.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b3e05d2c-3ca2-44af-a1ec-2af4c21e8d09

📥 Commits

Reviewing files that changed from the base of the PR and between 5b873a4 and d8a19b4.

📒 Files selected for processing (2)
  • config/antigravity/hooks.json
  • spec/antigravity_config_spec.sh
💤 Files with no reviewable changes (1)
  • config/antigravity/hooks.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Removed the orca-status hook from Antigravity configuration.
    • Updated installation and cleanup behavior to reflect the removal of this hook.
    • Existing moshi-hook and traces-share-to-traces hooks remain unchanged.

Walkthrough

The Antigravity configuration no longer defines the orca-status hook. Its specification now expects only moshi-hook and traces-share-to-traces, and verifies removal of a preexisting orca-status hook.

Changes

Antigravity hook cleanup

Layer / File(s) Summary
Managed hook removal validation
spec/antigravity_config_spec.sh
The install assertion excludes orca-status. The revert test seeds and verifies removal of a preexisting orca-status hook.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to d8a19

This change removes the managed orca-status hook and verifies that activation removes it from the live configuration; no actionable merge-blocking risk remains after normal checks and review.

Poem

A rabbit checks the hooks at dawn

orca-status has hopped along
Two trusted hooks remain in place
The tests confirm the cleaner space
Soft paws close the config change

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing the orca-status named hook from the managed Antigravity configuration.
Description check ✅ Passed The description directly explains the removal of orca-status, the related spec updates, the activation behavior, and the test result.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch antigravity-drop-orca-hook

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@shunkakinoki
shunkakinoki merged commit bc134f1 into main Aug 28, 2026
35 of 40 checks passed
@shunkakinoki
shunkakinoki deleted the antigravity-drop-orca-hook branch August 28, 2026 10:02
@linear-code

linear-code Bot commented Aug 28, 2026

Copy link
Copy Markdown

SHUN-3110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant