Make logical operators short-circuit where possible - #750
Open
triallax wants to merge 1 commit into
Open
Conversation
More efficient but also in line with most other languages out there.
Goju-Ryu
reviewed
Jul 7, 2025
Goju-Ryu
left a comment
Goju-Ryu
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this contribution, I’m excited to see short-circuiting being added to numbat.
I don't have a good enough understanding of this part of the project to give much feedback, but it looks really promising. I had two comments, mostly just to clarify some points.
|
|
||
| let else_block_offset = self.vm.current_offset(); | ||
| self.vm | ||
| .patch_u16_value_at(jump_offset, else_block_offset - (jump_offset + 2)); |
Contributor
There was a problem hiding this comment.
This is a bit unclear to me. I think I follow, but a comment to explain what is happening would be helpful.
Contributor
Author
|
now i also realise documenting this behaviour, even if briefly is probably useful, so i'll add that in as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More efficient but also in line with most other languages out there.