fix: keep draft reply quotes per conversation#1959
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
devbranchyarn readyrun passes successfully (more about tests here)Description
Fixes #535
Draft reply quotes are now stored by conversation, so switching away from a conversation and coming back keeps the draft associated with the message it was replying to
Tests cover keeping separate draft reply quotes for different conversations and clearing only the active conversation's quote
Tested:
pnpm readycorepack pnpm build:protobufcorepack pnpm exec prettier --check ts/state/ducks/conversations.ts ts/state/selectors/conversations.ts ts/test/session/unit/selectors/conversations_test.tscorepack pnpm exec eslint ts/state/ducks/conversations.ts ts/state/selectors/conversations.ts ts/test/session/unit/selectors/conversations_test.tscorepack pnpm exec tsc --noEmit --pretty false --project tsconfig.json./node_modules/.bin/babel dist --out-dir app --extensions .jsIS_UNIT_TEST=1 ./node_modules/.bin/mocha --no-config --exit --require jsdom-global/register --require ./dist/ts/test/test-utils/setup.js --timeout 10000 './dist/ts/test/session/unit/selectors/conversations_test.js'