Remove InPlaceSeed public re-export - #2992
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This struct was added into
serde_core::deby #2608 when it was not previously exposed byserde::de. I saw this in the review and tried to remove it in #2962/#2969 but 5ac3d84 was incomplete.I am not opposed to exposing a helper in some form, maybe even this form, just not silently as part of an unrelated refactor. It would need a dedicated PR with use case.
deserialize_in_placeis niche functionality so it is unlikely that someone has immediately come to rely on theInPlaceSeedtype since then.