feat: complete stable voting portal CSS hooks - #3147
Draft
Findeton wants to merge 1 commit into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/13192
Complete stable CSS hooks across the six voting screens, shared header/menus/dialogs, ballot cards, controls and sections. Preserve existing classes; IconButton gains buttonClassName for the control while className remains on its SVG. Document the selector contract and the complete confirmation Ballot ID row hide rule in Docusaurus.
Verification: 37 shared-UI and 67 voting-portal tests pass; the new compatibility regression fails before and passes after. Touched-file lint/format and ui-essentials build pass. Browser preview checks cover Ballot List, Instructions, Vote, Review, Confirmation, locator search/not-found result, shared controls and portaled dialog hooks. At desktop and 390px, the documented CSS rule hides the complete Ballot ID row and all its controls while QR, its accessible label, Print and Finish remain available; Tab goes directly to Print. Removing the temporary rule restores default visibility. No real vote cast; no test CSS committed. Successful locator payload/logs were inspected in source, not exercised in the preview. Local TypeScript diagnostics exactly match the release baseline.
Merge coordination: this is independent of the other accessibility PRs, but overlaps navigation markup in #3144. Merge this CSS-hook PR last and retain the new classes on the single navigation elements when resolving overlaps. No Beyond submodule change.