馃悶 Voting Portal: Correct heading and static-information semantics - #3146
Draft
Findeton wants to merge 2 commits into
Draft
馃悶 Voting Portal: Correct heading and static-information semantics#3146Findeton wants to merge 2 commits into
Findeton wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/13191
Render ballot-card titles as h2, footer attribution (including translation-error feedback) as paragraphs, and version/hash as static text instead of disabled buttons. Preserve existing CSS hooks, typography, dimensions and responsive visibility.
Verified: all four semantic regressions fail before and pass after; all 40 shared-UI tests, touched-file ESLint/Prettier, and the ui-essentials build pass. Browser accessibility-tree and computed-style checks confirm the heading list, static version/hash, preserved footer link and matching version dimensions. Checked desktop, 768px and 390px widths. Actual screen-reader speech remains a manual verification item; no claim that version/hash were previously Tab stops.