馃悶 Voting Portal: Improve checkbox and keyboard focus contrast - #3145
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the 鈿欙笍 Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Findeton
changed the title
Findeton
marked this pull request as ready for review
September 7, 2026 00:49
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/13190
Darken enabled unchecked checkbox boundaries to #757575 and add a persistent two-tone keyboard-focus ring to shared checkboxes and icon buttons. Keep labels, toggle handlers, checked colors and ripple behavior unchanged. Rebuild ui-essentials when consuming the change.
Verified: contrast/focus tests fail before and pass after; all 40 shared-UI tests and 9 eligibility tests pass; touched-file ESLint/Prettier and ui-essentials development build pass. Browser checks on the configured demo tenant cover help icons, checked/unchecked eligibility and candidate controls, Space toggling, and desktop/390px mobile layouts. Focus is independent of custom icon color. Tenant CSS that explicitly overrides control styles still needs its own contrast check.