Repository navigation
fix: batch files in lint hook to avoid ARG_MAX on large repos - #4
Merged
Merged
Conversation
On repositories with thousands of .nf files (e.g. nf-core/modules), pre-commit passes all matching filenames as CLI arguments, exceeding the OS ARG_MAX limit. Process files in batches of 200 to stay within the limit while keeping JVM startup overhead reasonable. Generated by Claude Code
On success, shows a single line: '✅ Nextflow lint passed (N files)' On failure, dumps full output so errors are easy to find. Generated by Claude Code
Let nextflow lint output stream directly so errors are always visible. The per-batch success noise is a nextflow lint UX issue tracked upstream (nextflow-io/nextflow#6856). Generated by Claude Code
Capture output from all batches and always display it, but filter out 'Nextflow linting complete!' and 'files had no errors' summary lines. Errors, warnings, and diagnostics are never hidden. Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.nffiles)nextflow lint, which can exceed the OSARG_MAXlimit (argv + envp combined)Context
Reported from https://github.com/nf-core/modules/actions/runs/22347821806/job/64668726513?pr=10241#step:4:156
The error manifests as every
execve()inside the Nextflow launcher script failing: