Add option to output cmd stdout with check-cmd

[lahdekorpi]

Purpose

Adds a flag to allow outputting the stdout of the command. Helps with getting status information about a command.

[majormoses]

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

[majormoses]

Hmm it looks like rubocop is pointing out that there is quite of bit of nesting conditionals which often leads to buggy code and poor performance. I see a couple ways we can improve this:

• I know you did not write this but we could rewrite to avoid using the ok, unknown, critical, and warning methods in any function other than run. By returning the status instead we have more options to better error handle and write cleaner code.
• the other option is to always set the message to include the stdout regardless if they want to check the stdout or not. Reading the description I feel that should be the case anyways or the description should be modified to further clarify that this option does not apply when check output is not specified.

[lahdekorpi]

I'd love to rewrite this, but I'm not really a Ruby programmer so I'm not sure if I'd be qualified.

[majormoses]

I'd love to rewrite this, but I'm not really a Ruby programmer so I'm not sure if I'd be qualified.

No worries, I won't try to pressure you into doing something you are uncomfortable with.

I consider myself a sysadmin who can write ruby more than a ruby programmer but if I have some time this weekend I will try to work on a re-write ping me next week if I have not replied here.

[lahdekorpi]

@majormoses Did you have time to look at this?

[majormoses]

@lahdekorpi sorry I did not have the time and thanks for pinging me. Maybe the best thing would be to put inline rubocop disables and a TODO: comment to come fix it up later. @mattyjones do you agree or should we gate this until I have time to look at refactoring it?

[majormoses]

btw this looks wrong to me I am guess this is meant to be ok status.

[majormoses]

@lahdekorpi I finally had the time to sit down with this for a bit (honestly I'd love to find the time to rewrite it entirely) of refactoring. As there are a lack of useful automated tests if you can help with running some tests and sharing the results here it that would be appreciated.