Skip to content

AmB2BMedia::writeStream: guard zero sample rate to prevent SIGFPE crash #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hecko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AmB2BMedia::writeStream: guard zero sample rate to prevent SIGFPE crash #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/AmB2BMedia.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,11 @@ int AudioStreamData::writeStream(unsigned long long ts, unsigned char *buffer, A
if (stream->sendIntReached(ts)) {
// A leg is ready to send data
int sample_rate = stream->getSampleRate();
// getSampleRate() returns 0 when the stream format is not set yet (or a
// zero-clock-rate codec was negotiated); sample_rate is used as a divisor
// deeper in the AmAudio chain (e.g. AmBufferedAudio::get) and would raise
// SIGFPE. Mirror the guard already applied in AmSession::writeStreams.
if (sample_rate == 0) return 0;
int got = 0;
if (in) got = in->get(ts, buffer, sample_rate, f_size);
else {
Expand Down
Loading