Remove pull request guard#2475
Draft
samchungy wants to merge 6 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 95eb353 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samchungy
marked this pull request as ready for review
June 19, 2026 06:45
72636c
approved these changes
Jun 19, 2026
|
|
||
| skuba previously skipped pushing autofixes on Renovate branches when no open pull request was associated with the current commit, as this would interfere with Renovate's pull request creation | ||
|
|
||
| If you notice any issues with skuba Renovate branches stuck in an edited or blocked state, please reach out in #skuba-support. |
Member
There was a problem hiding this comment.
How would teams notice this? Would the branches be visibly stuck in the Dependency Dashboard without an option to force-raise the PR?
Is there something check we could run against the gh CLI in e.g. 60 days to see if there is an increase in stale Renovate branches across the org?
Comment on lines
+5
to
+9
| lint: Remove Renovate pull request guard from autofix | ||
|
|
||
| skuba previously skipped pushing autofixes on Renovate branches when no open pull request was associated with the current commit, as this would interfere with Renovate's pull request creation | ||
|
|
||
| If you notice any issues with skuba Renovate branches stuck in an edited or blocked state, please reach out in #skuba-support. |
Member
There was a problem hiding this comment.
Suggested change
| lint: Remove Renovate pull request guard from autofix | |
| skuba previously skipped pushing autofixes on Renovate branches when no open pull request was associated with the current commit, as this would interfere with Renovate's pull request creation | |
| If you notice any issues with skuba Renovate branches stuck in an edited or blocked state, please reach out in #skuba-support. | |
| lint: Push autofixes on Renovate branches without an open pull request | |
| A race condition can occur when skuba is ready to push [GitHub autofixes](https://seek-oss.github.io/skuba/docs/deep-dives/github.html#github-autofixes) to a Renovate branch before the bot opens a corresponding pull request. skuba previously skipped the push operation in this scenario, which ensured Renovate would reliably proceed to pull request creation but required human intervention to subsequently apply fixes to the branch. Recent improvements to the [`gitIgnoredAuthors`](https://docs.renovatebot.com/configuration-options/#gitignoredauthors) configuration option in Renovate should allow skuba to safely push autofixes ahead of pull request creation. | |
| [Reach out](https://github.com/seek-oss/skuba/blob/main/CONTRIBUTING.md#i-want-to-discuss-or-report-something) if you notice your Renovate branches are getting stuck in an edited or blocked state. |
samchungy
marked this pull request as draft
July 15, 2026 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This existed before Aaron's fix Renovate to recognise buildagencytoken as a bot