-
Notifications
You must be signed in to change notification settings - Fork 41
Upgrade pnpm #2388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zbrydon
wants to merge
34
commits into
main
Choose a base branch
from
upgrade-pnpm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade pnpm #2388
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
5db8ab8
Upgrade pnpm
zbrydon d358f0a
ermmm
zbrydon bfdb0b8
We have to use the same version that `pnpm/action-setup` uses? 🤔
zbrydon 34d5dde
And the rest
zbrydon 150afb9
I suspect things are not working as they should
zbrydon 3d82923
install
zbrydon ef4393f
ts-ignore
zbrydon 9fd34be
Fix
zbrydon 026e936
Fix more
zbrydon deb713b
Merge branch 'main' of github.com:seek-oss/skuba into upgrade-pnpm
zbrydon a88eac6
Use pnpm v11.1
zbrydon 88d3eac
More updates
zbrydon 085af02
Fix
zbrydon 9181263
Format
zbrydon 5ae3e45
Merge branch 'main' into upgrade-pnpm
zbrydon e7f6736
Use new release
zbrydon e9f9db0
Merge branch 'main' of github.com:seek-oss/skuba into upgrade-pnpm
zbrydon 2b6fd40
Try this
zbrydon f6d99cc
Test enabling `strictDepBuilds` & `trustPolicy`
zbrydon 4fbf71d
snapshot & update version
zbrydon 689ed6e
repatch `pnpm-workspace.yaml`
zbrydon 5da1280
mhmm
zbrydon 0516fc9
Still broken in v11
zbrydon 483d2c7
Merge branch 'main' of github.com:seek-oss/skuba into upgrade-pnpm
zbrydon 330d49f
Move patch
zbrydon b3304ac
Use mjs
zbrydon ae14e69
Use new types that still aren't updated...
zbrydon 8e5fdbb
Merge branch 'main' of github.com:seek-oss/skuba into upgrade-pnpm
zbrydon 59446a7
Update pnpm-lock.yaml
zbrydon 7098f0f
Fix bad merge
zbrydon 4b551f9
use correct types, `.mjs` and re-enable settings
zbrydon 91fb694
Update pnpm version
zbrydon b4aea2d
Words
zbrydon 53b7187
Add changesets patch while we wait for v3
zbrydon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'skuba': minor | ||
| --- | ||
|
|
||
| lint: Run pnpm codemod to upgrade to pnpm v11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| 'pnpm-plugin-skuba': minor | ||
| --- | ||
|
|
||
| Support pnpm 11 | ||
|
|
||
| - Migrated the pnpmfile from CommonJS (`pnpmfile.cjs`) to ESM (`pnpmfile.mjs`). | ||
| - Re-enabled `strictDepBuilds` and set `trustPolicy` to `no-downgrade`. | ||
| - Replaced `packageManagerStrictVersion` with `pmOnFail: error`, removing the now-unnecessary `ignorePatchFailures` setting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| diff --git a/dist/changesets-cli.cjs.js b/dist/changesets-cli.cjs.js | ||
| index 9f0bd6c5f96011be225269a71365a878cb822bb7..6e7267d88b66868f144b531763a000bfa197483e 100644 | ||
| --- a/dist/changesets-cli.cjs.js | ||
| +++ b/dist/changesets-cli.cjs.js | ||
| @@ -824,12 +824,12 @@ function getPackageInfo(packageJson) { | ||
|
|
||
| // Bare query: when dist-tags.latest is set, returns the full `versions` array via packument | ||
| // bleed-through, enabling only-pre detection downstream. Returns empty when no `latest` exists. | ||
| - let result = await spawn__default["default"]("npm", ["info", packageJson.name, `--${scope ? `${scope}:` : ""}registry=${registry}`, "--json"]); | ||
| + let result = await spawn__default["default"]("pnpm", ["info", packageJson.name, `--${scope ? `${scope}:` : ""}registry=${registry}`, "--json"]); | ||
|
|
||
| // Bare query returned nothing — retry with exact version specifier | ||
| // to handle prerelease-only packages on registries without auto-`latest`. | ||
| if (result.stdout.toString() === "") { | ||
| - result = await spawn__default["default"]("npm", ["info", `${packageJson.name}@${packageJson.version}`, `--${scope ? `${scope}:` : ""}registry=${registry}`, "--json"]); | ||
| + result = await spawn__default["default"]("pnpm", ["info", `${packageJson.name}@${packageJson.version}`, `--${scope ? `${scope}:` : ""}registry=${registry}`, "--json"]); | ||
| } | ||
|
|
||
| // Normalize, just in case. The above prerelease-only package query should already have returned: | ||
| diff --git a/dist/changesets-cli.esm.js b/dist/changesets-cli.esm.js | ||
| index d9582bf53eaf55402a6bf96a39589af7854b8f23..e4224856a038284171250e519c64a7ad307b65cf 100644 | ||
| --- a/dist/changesets-cli.esm.js | ||
| +++ b/dist/changesets-cli.esm.js | ||
| @@ -787,12 +787,12 @@ function getPackageInfo(packageJson) { | ||
|
|
||
| // Bare query: when dist-tags.latest is set, returns the full `versions` array via packument | ||
| // bleed-through, enabling only-pre detection downstream. Returns empty when no `latest` exists. | ||
| - let result = await spawn$1("npm", ["info", packageJson.name, `--${scope ? `${scope}:` : ""}registry=${registry}`, "--json"]); | ||
| + let result = await spawn$1("pnpm", ["info", packageJson.name, `--${scope ? `${scope}:` : ""}registry=${registry}`, "--json"]); | ||
|
|
||
| // Bare query returned nothing — retry with exact version specifier | ||
| // to handle prerelease-only packages on registries without auto-`latest`. | ||
| if (result.stdout.toString() === "") { | ||
| - result = await spawn$1("npm", ["info", `${packageJson.name}@${packageJson.version}`, `--${scope ? `${scope}:` : ""}registry=${registry}`, "--json"]); | ||
| + result = await spawn$1("pnpm", ["info", `${packageJson.name}@${packageJson.version}`, `--${scope ? `${scope}:` : ""}registry=${registry}`, "--json"]); | ||
| } | ||
|
|
||
| // Normalize, just in case. The above prerelease-only package query should already have returned: |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not published yet 🫠
https://www.npmjs.com/package/@pnpm/config/v/1004.11.1?activeTab=code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was also running into this maybe? 🙃