[WJ-1060] Avoid exponential parsing of nested unclosed blocks - #129
Open
jsthope wants to merge 15 commits into
Open
[WJ-1060] Avoid exponential parsing of nested unclosed blocks#129jsthope wants to merge 15 commits into
jsthope wants to merge 15 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 71.17% 71.40% +0.22%
==========================================
Files 220 220
Lines 6234 6266 +32
==========================================
+ Hits 4437 4474 +37
+ Misses 1797 1792 -5
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
emmiegit
reviewed
Aug 1, 2026
Member
|
Good enhancements! I had a few comments. |
Co-authored-by: Emmie <emmie.maeda@gmail.com>
Co-authored-by: Emmie <emmie.maeda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see WJ-1060
This PR improves handling of malformed and unclosed blocks by memoizing terminal EndOfInput failures for block and block-star rules.
And by including relevant parser state in the cache key including bibliography state.