Skip to content

fix loc and allow effects to construct factories above limit #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schombert merged 1 commit into from
May 28, 2026
Merged

fix loc and allow effects to construct factories above limit #2274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/localisation/en-US/alice.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,7 +1516,7 @@ demand;Demand
supply_demand_ratio;Supply-demand ratio
balance;Balance
market_stockpiles;In stock
national_stockpile;Government Stockpile
national_stockpile;Stockpile
government_need;Government procurement
factory_need;Factory inputs
pop_need;Population needs
Expand Down
6 changes: 2 additions & 4 deletions src/economy/economy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5415,11 +5415,9 @@ void try_add_factory_to_state(sys::state& state, dcon::state_instance_id s, dcon
return; // can't build another of this type
}

auto urbanisation = state.world.province_get_advanced_province_building_max_private_size(province, advanced_province_buildings::list::local_cities_and_towns);
// do not limit it here because it feels bad to get factory reward from event not appearing at all

if(num_factories < int32_t(state.defines.factories_per_state * urbanisation / economy::factories_per_state_required_city_size)) {
add_factory_level_to_province(state, province, t);
}
add_factory_level_to_province(state, province, t);
}

command::budget_settings_data budget_minimums(sys::state& state, dcon::nation_id n) {
Expand Down
Loading