Fix KeyError/IndexError on negative ordinals in Hindi and Arabic#672
Open
santhreal wants to merge 1 commit into
Open
Fix KeyError/IndexError on negative ordinals in Hindi and Arabic#672santhreal wants to merge 1 commit into
santhreal wants to merge 1 commit into
Conversation
Hindi to_ordinal_num mapped str(value) through a digit-only table, so negatives and floats raised KeyError on '-' or '.'. Arabic to_ordinal indexed arabicOrdinal with negatives (returning the wrong ordinal) and crashed on larger negatives in convert. Both now call verify_ordinal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arabic to_ordinal indexes arabicOrdinal with negatives, and Hindi to_ordinal_num KeyErrors on negatives/floats. Call verify_ordinal so both raise TypeError like other languages.