Repository navigation
Conversation
CallerID cannot name a caller from another realm and resolves to the empty string there. AddMember accepted "" as a member id, so a single such member let any unidentified cross-realm caller pass the member gate and propose, vote and execute. - AddMember rejects an empty member id, which also covers the NewMembersStore initial-members path. - New records the realm it was handed rather than reading unsafe.CurrentRealm(), which returns the borrower. - The member-only README example is a crossing function reading cur.Previous() under an IsCurrent guard, instead of stack-walking with unsafe.PreviousRealm() in a non-crossing function.
|
@davd-gzl thanks for this — closing because it has landed, not because it was dropped. Your The one part I did not take is the change to Related: your #15 is closed by this work too — that was P0-B, and a foreign realm can no longer make the DAO act under its identity. I know you declined the interface-breaking scope here, and #69–#72 went ahead with it because the topaz-1 publish is immutable and it was now-or-never. Genuinely open to feedback on any of it — if you disagree with a call, say so and we'll revisit before the ceremony runs. |
Stacked on #65 and targeting its branch.
A DAO cannot identify a caller from another realm, so
CallerIDresolves to the empty string there.AddMemberaccepted""as a member id, so one such member let any unidentified cross-realm caller pass the member gate and propose, vote and execute. Rejecting it closes that, including theNewMembersStorepath.Newnow records the realm it was handed instead of readingunsafe.CurrentRealm(), which returns the borrower, and the member-only README example readscur.Previous()under anIsCurrentguard instead of stack-walking in a non-crossing function.Verified at the topaz-1 launch tip
fc4052651: packages and demo realms green, lint clean, three new tests, and the fixture that previously let a foreign realm write through the DAO now fails at construction. TheExecuterealm threading and the lambda handler are untouched, since both change public interfaces.