Add Manual featurefilt mode to processing() and feature_filtering(). - #125
Open
giuliaroeth wants to merge 1 commit into
Open
Add Manual featurefilt mode to processing() and feature_filtering().#125giuliaroeth wants to merge 1 commit into
giuliaroeth wants to merge 1 commit into
Conversation
…Lets users flag features to remove via a metadata_feature column instead of a cutoff rule. Falls back to Modified, then Standard, with a warning, if the expected column or Conditions data isn't usable. Adds a Feature_matrix output sheet listing every feature's filter status. Changes: processing() and feature_filtering() in R/Processing.R; check_param_feature_filtering() in R/HelperChecks.R; updated the RemovedMetabolites assertion in tests/testthat/test-processing-and-analysis.R to match feature_filtering() new DF/FilteredFeatures return shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets users flag features to remove via a metadata_feature column instead of a cutoff rule. Falls back to Modified, then Standard, with a warning, if the expected column or Conditions data isn't usable. Adds a Feature_matrix output sheet listing every feature's filter status. Changes: processing() and feature_filtering() in R/Processing.R; check_param_feature_filtering() in R/HelperChecks.R; updated the RemovedMetabolites assertion in tests/testthat/test-processing-and-analysis.R to match feature_filtering() new DF/FilteredFeatures return shape.