Repository navigation
Fixes dialog style - #70
Merged
Merged
Conversation
Sam Beveridge (00salmon)
requested review from
a team
and
a balanced review from Copilot
September 2, 2026 22:07
|
A preview of d872365 is uploaded and can be seen here: |
size-limit report 📦
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The 2.8.5 changelog comparison incorrectly starts from 2.8.2 instead of 2.8.4.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds inline dialog centering to prevent global styles from changing popup margins.
Changes:
- Sets popup dialog margin to
auto. - Updates unit and feature coverage.
- Bumps the package to 2.8.5 with release notes.
File summaries
| File | Description |
|---|---|
src/widgets/PopupWidget.ts |
Adds the inline dialog margin. |
test/tests/PopupWidget.test.ts |
Verifies the margin style. |
test/specs/PopupWidget.feature |
Updates expected popup styles. |
package.json |
Bumps the package version. |
package-lock.json |
Synchronizes package versions. |
CHANGELOG.md |
Documents 2.8.5 and updates release links. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AndiLuo
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Links
Checklists
Development
Paperwork
Code review