[Sam Beveridge (00salmon)]

Description of the change

Fixes an issue where Shopify themes sometimes have global overrides to margin, causing our popup widgets to be misplaced

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation or Development tools (readme, specs, tests, code formatting)

Links

• Jira issue number: (PUT IT HERE)
• Process.st launch checklist: (PUT IT HERE)

Checklists

Development

• Prettier was run (if applicable)
• The behaviour changes in the pull request are covered by specs
• All tests related to the changed code pass in development

Paperwork

• This pull request has a descriptive title and information useful to a reviewer
• This pull request has a Jira number
• This pull request has a Process.st launch checklist

Code review

• Changes have been reviewed by at least one other engineer
• Security impacts of this change have been considered

[github-actions]

A preview of is uploaded and can be seen here:

✨ https://saasquatch.github.io/squatch-js/pull/69 ✨

[github-actions]

size-limit report 📦

Path	Size
dist/squatch.js	13 KB (+0.06% 🔺)

[Copilot]

🟢 Approved

The focused fix is covered by updated unit and feature expectations with no unresolved issues.

Pull request overview

Fixes popup dialog positioning when Shopify themes override global margins.

Changes:

• Adds margin: auto to popup dialogs.
• Updates unit and feature expectations.

File summaries

File	Description
test/tests/PopupWidget.test.ts	Verifies the inline margin style.
test/specs/PopupWidget.feature	Updates expected popup styles.
src/widgets/PopupWidget.ts	Explicitly centers popup dialogs.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.