Repository navigation
fix: pin the bundled Camoufox build to 152.0.4-beta.31 - #5
Merged
Merged
Conversation
Camoufox 156.0.1-beta.34 became the latest stable release on 3 October. camoufox-js 0.11.5 still generates config properties that 156 removed, such as navigator.product, so every launch fails with "Unknown property ... in config". Install the last build verified with this camoufox-js, and point fetch-bin and the remediation messages at the pinned downloader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the bundled Camoufox download to 152.0.4-beta.31. Camoufox 156.0.1-beta.34 became the latest stable release at 22:03 UTC on 3 October. camoufox-js 0.11.5 still generates config properties that 156 removed, such as
navigator.product, so every launch on a fresh install fails withUnknown property navigator.product in config. Master run 37170178094 failed this way ine2e (24),windows-e2eandwindows-process-cleanup; the previous green run fetched 152.0.4-beta.31.postinstall.js / npm run fetch-bin downloadBundledCamoufox() - new CamoufoxFetcher() // latest stable release + new PinnedCamoufoxFetcher() // only 152.0.4-beta.31, searches 100 releasesfetch-binnow runsscripts/fetch-camoufox.js, becausenpx camoufox-js fetchwould install 156 again. The remediation messages inpostinstall.js,server.js,run.shandREADME.mdpoint tonpm run fetch-bin.camoufox-js 0.12.0, the latest on npm, keeps the same property mapping. apify/camoufox-js#339 filters the generated keys but is unmerged. Raise the pin and camoufox-js together once a release supports 156.
Evidence
camoufox launch attempt failed ... Unknown property navigator.product in configon every launch.After: on Linux (Node 26, private
CAMOUFOX_INSTALL_DIR),npm run fetch-bininstalled{"version":"152.0.4","release":"beta.31"}and the e2e config passed 15 suites, 80/80 tests, with noUnknown propertylines.scripts/postinstall.test.jspassed 4/4, including a new test that the fetcher accepts the pinned asset and rejects 156.0.1-beta.34.Merge danger
Door: two-way. Blast radius: browser installs
New installs and
npm run fetch-binget 152.0.4-beta.31 instead of the latest release. Existing caches are unchanged.Unverified
win.x86_64andwin.i686assets; this PR's CI covers them.tests/unit/security.test.jscases time out onPOST /tabsand the yt-dlp install test fails withoutshasum. Master fails the same four security cases there with the same browser build, and CI passed them on 3 October.