[Breaking draft] Tweak block::Generator to support fast-key-erasure - #81
Draft
dhardy wants to merge 5 commits into
Draft
[Breaking draft] Tweak block::Generator to support fast-key-erasure#81dhardy wants to merge 5 commits into
block::Generator to support fast-key-erasure#81dhardy wants to merge 5 commits into
Conversation
dhardy
marked this pull request as draft
August 20, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Tweak the
block::Generatortrait to support fast-key-erasure: RustCrypto/stream-ciphers#578Also removes
BlockRng::{reconstruct, remaining_results}since to my knowledge these are only used by the (mostly abandoned) Isaac generators.Motivation
It turns out we can fit a low-overhead fast-key-erasure generator into our existing ecosystem with only some small tweaks here. (Larger changes to the
blockcode may be warranted; this is more a proof-of-concept with minimal changes.)Details
Generator::Word. Note that we require (without trait bound) thatGenerator::Outputis[Word; N]for someNand thatNis not currently an associated constant; ideally we'd addNand removeOutputbut this requires improved const generics support IIRC.Generator::erase. Note that this does a different job todrop:eraseis used for fast-erasure (only, and without feature requirements) whiledropis used tozeroizethe buffer on drop (if that feature is enabled).Generator::generatereturn the index of the first available value in the buffer.