Allow building as dependency on docs.rs with no features enabled - #199
Merged
Conversation
MarijnS95
reviewed
Aug 13, 2025
MarijnS95
left a comment
MarijnS95
left a comment
Member
There was a problem hiding this comment.
Unless I'm reading this wrong, we already tried to enable the native-activity backend by default for cfg(doc), i.e. a user runs cargo doc in this repository.
Is that also not set on docs.rs for dependency crates?
madsmtm
force-pushed
the
build-on-docsrs
branch
from
September 4, 2025 22:35
de034e2 to
ca141a1
Compare
Member
Author
Nope. |
Member
Author
|
Bump? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
winit, we have to artificially enable an activity to get the docs to build on Android, which is kinda annoying:https://github.com/rust-windowing/winit/blob/969237f422e3d1d18821f4ee99e6be7bb6acd913/Cargo.toml#L125-L126
Instead, this PR proposes to handle that logic internally in
android-activity, by relying on the fact that docs.rs sets an environment variable (see their docs).Fixes #117.