Remove our cynic dependency - #2471
Conversation
There was a problem hiding this comment.
Fully agreed that just writing these queries by hand is easier to read, understand and modify, and in general just much less magic happening. I'd be happy to see this dependency go away :)
That being said, since this is a rather large change, I think that we should do a vibe check on the triagebot Zulip channel about it.
| let mut data = self | ||
| .graphql_query( | ||
| r#" | ||
| query LeastRecentlyReviewedPullRequests( |
There was a problem hiding this comment.
Seems like a good case for the local GH database mirror, to avoid these kinds of remote GH queries :)
There was a problem hiding this comment.
what do you mean by local gh db? do you mean that to cache results of this query? This specific query is run when I prepare the weekly triage agenda, I need fresh data everytime
There was a problem hiding this comment.
I meant https://rust-lang.zulipchat.com/#narrow/channel/224082-triagebot/topic/Integrating.20a.20GitHub.20mirror.20.2B.20dashboard.20in.20triagebot/with/612107852, if we had the GitHub mirror in the triagebot DB, this could just be an SQL query (potentially with a force-refresh before running the data if up-to-date state is required).
There was a problem hiding this comment.
the "force-refresh" part is def. needed for my queries :)
3 participants
Our
cycnicdependency has bothered me for quite a while now.This PR removes it by moving the two queries to our queries system. Saving a build script and 40 deps to build!
I've tested both migrated queries. Seems to work as expected.