Skip to content

Configure trusted publishing for futures-rs #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kobzol wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Configure trusted publishing for futures-rs #2594

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a131ec
Configure trusted publishing for futures-rs
Kobzol Jul 18, 2026
6f6752c
Change publish branch
Kobzol Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions repos/rust-lang/futures-rs.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,23 @@ pattern = "main"
required-approvals = 0

[environments.github-pages]

[environments.publish]
branches = ["main"]
Comment thread
Kobzol marked this conversation as resolved.
Outdated

[[crates-io]]
crates = [
"futures",
"futures-channel",
"futures-core",
"futures-executor",
"futures-io",
"futures-macro",
"futures-sink",
"futures-task",
"futures-test",
"futures-util",
]
publish-workflow = "publish.yml"
publish-environment = "publish"
teams = ["wg-async"]

@taiki-e taiki-e Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an approver? Since cramertj stopped being involved (5-6 years ago?) I'm the only current member of wg-async who has been involved in maintaining futures-rs, it seems odd that all wg members would have permission over releases.

@Kobzol Kobzol Jul 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specifies which team will own the crate on crates.io. But in practice with trusted publishing turned on, the only thing that this is useful for is yanking.

By the way, it would be great if the current active roster of wg-async was updated to match today's state!

@Mark-Simulacrum Mark-Simulacrum Jul 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically these people have access to turn off trusted publishing and manually publish, but that would be a loud-ish action. Long-term I personally would like us to remove all human access to crates.io' (probably proxying yanks via some github/zulip bot) and/or have stronger yank-only enforcemeent.