Skip to content

Stop passing -Zincremental-verify-ich #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xmakro wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −9
Open

Stop passing -Zincremental-verify-ich #2510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions collector/src/bin/rustc-fake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,6 @@ fn main() {
args.push(OsString::from("-Adeprecated"));
args.push(OsString::from("-Aunknown-lints"));

// This forces incremental query hash verification on. Currently, rustc
// hashes 1/32 of queries loaded from disk without this flag, but that 1/32
// is based on the (expected) hash of the data, which can vary from build to
// build, adding a source of noise to our measurements, which we prefer to
// avoid. rustc-perf can accept the higher cost of always verifying hashes,
// and we currently prefer to avoid exposing a means of hard-disabling
// verification.
args.push(OsString::from("-Zincremental-verify-ich"));

if let Some(pos) = args.iter().position(|arg| arg == "--wrap-rustc-with") {
// Strip out the flag and its argument, and run rustc under the wrapper
// program named by the argument.
Expand Down
Loading