Explicitly pass run_make_support rlib/rmeta paths to compiletest - #161102
Open
Kobzol wants to merge 1 commit into
Open
Explicitly pass run_make_support rlib/rmeta paths to compiletest#161102Kobzol wants to merge 1 commit into
Kobzol wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Kobzol
commented
Aug 14, 2026
| .arg("-o") | ||
| .arg(&recipe_bin) | ||
| // Specify library search paths for `run_make_support`. | ||
| .arg(format!("-Ldependency={}", &support_lib_path.parent().unwrap())) |
Member
Author
There was a problem hiding this comment.
This shouldn't be needed, AFAIK.
This comment has been minimized.
This comment has been minimized.
Kobzol
force-pushed
the
compiletest-runmake-passthrough
branch
from
August 14, 2026 16:37
8ef33e5 to
b2722ed
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 15, 2026
Explicitly pass run_make_support rlib/rmeta paths to compiletest try-job: aarch64-apple-darwin-1 try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: aarch64-msvc-1 try-job: x86_64-mingw-1 try-job: armhf-gnu
rust-bors
Bot
added
S-waiting-on-author
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 15, 2026
Explicitly pass run_make_support rlib/rmeta paths to compiletest try-job: aarch64-apple-1 try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: aarch64-msvc-1 try-job: x86_64-mingw-1 try-job: armhf-gnu
jieyouxu
added
S-waiting-on-review
jieyouxu
approved these changes
Aug 15, 2026
Member
There was a problem hiding this comment.
Thanks, I tested this locally on x86_64 msvc as well
@bors r+ rollup
Member
There was a problem hiding this comment.
NB: I edited the PR description to not use "resolve cargo-issue-number" since apparently that triggers the github magic comment, lol
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 15, 2026
…ough, r=jieyouxu Explicitly pass run_make_support rlib/rmeta paths to compiletest This should unblock rust-lang#151061, and helps with rust-lang/cargo#17359 from the side of run-make-support. I tested this with `-Zembed-metadata=no` applied to everything (in `Builder::cargo`), it works now both with and without it (that's not to say that applying `-Zembed-metadata=no` won't break something else, ofc). CC @bjorn3 r? jieyouxu --- try-job: aarch64-apple-1 try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: aarch64-msvc-1 try-job: x86_64-mingw-1 try-job: armhf-gnu
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 15, 2026
…uwer Rollup of 5 pull requests Successful merges: - #160203 (`Iterator::{min,max}(_by_key)` should use overridden `min`/`max`/`lt`) - #159862 (Update expect messages for library/alloc/src/vec/mod.rs) - #160719 (Improve OpenOptions append+truncate error message) - #160996 (Forward all array `PartialOrd` to slices) - #161102 (Explicitly pass run_make_support rlib/rmeta paths to compiletest)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should unblock #151061, and helps with rust-lang/cargo#17359 from the side of run-make-support.
I tested this with
-Zembed-metadata=noapplied to everything (inBuilder::cargo), it works now both with and without it (that's not to say that applying-Zembed-metadata=nowon't break something else, ofc).CC @bjorn3
r? jieyouxu
try-job: aarch64-apple-1
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: aarch64-msvc-1
try-job: x86_64-mingw-1
try-job: armhf-gnu