Skip to content

2026/08/12 -- hrsraiden -- bootstrap: warn when download-ci-llvm is unavailable with assertions - #160959

Closed
HRSRaiden wants to merge 1 commit into
rust-lang:mainfrom
HRSRaiden:fix-160919-ci-llvm-warning
Closed

2026/08/12 -- hrsraiden -- bootstrap: warn when download-ci-llvm is unavailable with assertions#160959
HRSRaiden wants to merge 1 commit into
rust-lang:mainfrom
HRSRaiden:fix-160919-ci-llvm-warning

Conversation

@HRSRaiden

@HRSRaiden HRSRaiden commented Aug 12, 2026

Copy link
Copy Markdown

Fixes #160919.

When llvm.download-ci-llvm = true and llvm.assertions = true are set in config.toml, but no assertion-enabled alt CI LLVM binary exists for the host triple, bootstrap previously built LLVM from source silently without any notification.

This PR adds a WARNING and HELP message when download-ci-llvm = true is explicitly requested on an unsupported target.

Verification

  • cargo test --manifest-path src/bootstrap/Cargo.toml download_ci_llvm_unsupported_assertions (1 passed, 0.00s)
  • python x.py check (Passed)
  • python x.py fmt --check (Passed)

r? @jieyouxu
@rustbot label +A-bootstrap

When  and  are set on a target without alt CI LLVM, bootstrap silently built LLVM from source.nPrint a warning and help message instead.nFixes rust-lang#160919.
@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 12, 2026
@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Error: Unknown labels: A-bootstrap

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consult the LLM usage policy. Was this change created with an LLM?

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2026
@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@HRSRaiden

Copy link
Copy Markdown
Author

Please consult the LLM usage policy. Was this change created with an LLM?

View changes since this review

Yes, I used an LLM assistant to help explore the bootstrap codebase, trace the logic in parse_download_ci_llvm and suggest a fix.
Afterward, I made the changes and have confirmed the behaviour locally (python x.py check, cargo test, and python x.py fmt --check)
Since this is my first contribution, I used an LLM to simply the codebase for me and understand it. Let me know if I missed something or need any more change.

@jieyouxu

jieyouxu commented Aug 12, 2026

Copy link
Copy Markdown
Member

Please consult the LLM usage policy. Was this change created with an LLM?
View changes since this review

Yes, I used an LLM assistant to help explore the bootstrap codebase, trace the logic in parse_download_ci_llvm and suggest a fix. Afterward, I made the changes and have confirmed the behaviour locally (python x.py check, cargo test, and python x.py fmt --check) Since this is my first contribution, I used an LLM to simply the codebase for me and understand it. Let me know if I missed something or need any more change.

Thank you for the interest in contributing. Please consult the usage policy, where current rules for this repos are that code changes created originally by LLMs generally need to be pre-arranged with a consenting reviewer, and you need to understand the rationale for why the change is correct. You can visit #llm-reviews for examples of such pre-arrangements.

LLMs typically give you these

### Verification
- `cargo test --manifest-path src/bootstrap/Cargo.toml download_ci_llvm_unsupported_assertions` (1 passed, 0.00s)
- `python x.py check` (Passed)
- `python x.py fmt --check` (Passed)

which immediately tells the reviewer (me) that the verification isn't verifying the actual change.

I'm going to close this PR as per the LLM usage policy and rust-lang/compiler-team#893.

@jieyouxu jieyouxu closed this Aug 12, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 12, 2026
@HRSRaiden
HRSRaiden deleted the fix-160919-ci-llvm-warning branch August 12, 2026 08:03
@Kobzol

Kobzol commented Aug 12, 2026

Copy link
Copy Markdown
Member

This should be implemented in a different way, in a centralized place, once we actually have that centralized place for LLVM CI handling (#160916).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

llvm.download-ci-llvm = true + assertions = true with unavailable alt CI LLVM shows no warnings/errors, tries to build LLVM

4 participants