2026/08/12 -- hrsraiden -- bootstrap: warn when download-ci-llvm is unavailable with assertions - #160959
2026/08/12 -- hrsraiden -- bootstrap: warn when download-ci-llvm is unavailable with assertions#160959HRSRaiden wants to merge 1 commit into
Conversation
When and are set on a target without alt CI LLVM, bootstrap silently built LLVM from source.nPrint a warning and help message instead.nFixes rust-lang#160919.
|
This PR modifies If appropriate, please update |
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
|
Error: Unknown labels: A-bootstrap Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
There was a problem hiding this comment.
Please consult the LLM usage policy. Was this change created with an LLM?
|
Reminder, once the PR becomes ready for a review, use |
Yes, I used an LLM assistant to help explore the bootstrap codebase, trace the logic in |
Thank you for the interest in contributing. Please consult the usage policy, where current rules for this repos are that code changes created originally by LLMs generally need to be pre-arranged with a consenting reviewer, and you need to understand the rationale for why the change is correct. You can visit #llm-reviews for examples of such pre-arrangements. LLMs typically give you these which immediately tells the reviewer (me) that the verification isn't verifying the actual change. I'm going to close this PR as per the LLM usage policy and rust-lang/compiler-team#893. |
|
This should be implemented in a different way, in a centralized place, once we actually have that centralized place for LLVM CI handling (#160916). |
Fixes #160919.
When
llvm.download-ci-llvm = trueandllvm.assertions = trueare set inconfig.toml, but no assertion-enabled alt CI LLVM binary exists for the host triple,bootstrappreviously built LLVM from source silently without any notification.This PR adds a
WARNINGandHELPmessage whendownload-ci-llvm = trueis explicitly requested on an unsupported target.Verification
cargo test --manifest-path src/bootstrap/Cargo.toml download_ci_llvm_unsupported_assertions(1 passed, 0.00s)python x.py check(Passed)python x.py fmt --check(Passed)r? @jieyouxu
@rustbot label +A-bootstrap