Fix improper stability of Write for Cursor<W: WriteThroughCursor> - #160952
Merged
rust-bors[bot] merged 1 commit intoAug 12, 2026
Merged
Conversation
Was already stable when using explicit types (e.g. `Vec<u8>`). `WriteThroughCursor` is still unstable/hidden.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
@bors r+ rollup Thank you! |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 12, 2026
…bility_fix, r=clarfonthey Fix improper stability of `Write for Cursor<W: WriteThroughCursor>` Was already stable when using explicit types (e.g. `Vec<u8>`). `WriteThroughCursor` is still unstable/hidden. Tracking Issue: rust-lang#154046 Zulip Discussion: [#general > ✔ CI Failure With and Without Stability Attribute](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/.E2.9C.94.20CI.20Failure.20With.20and.20Without.20Stability.20Attribute/with/615974133) # Description Fixes an oversight in how the `Write for Cursor<W: WriteThroughCursor>` implementation was written. While `core::io` was unstable, a stability attribute for this implementation was not required. However, once that module is marked as stable (even when `Cursor` and `Write` are not publicly stably exported), a stability attribute is required. Since `Write` and `Cursor` are both stable items (just not stable to access via `core::io`), the implementation must be marked as stable. While it is possible to use [#[unstable_feature_bound(core_io)]](https://rustc-dev-guide.rust-lang.org/stability.html#unstable_feature_bound) to allow that implementation to be unstable, we do need users to have access to it stably, since it is how implementations such as `Write for Cursor<Vec<u8>>` are accessed. This is also why this implementation is marked as stable since `1.0.0`, since that is the earliest downstream implementation we must permit. --- ## Notes - No AI tooling of any kind was used during the creation of this PR.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 12, 2026
…uwer Rollup of 5 pull requests Successful merges: - #160900 (Ensure that restriction paths are ancestors) - #155846 (tests/ui/tuple: add annotations for reference rules) - #160890 (Disable some tests for ohos target) - #160952 (Fix improper stability of `Write for Cursor<W: WriteThroughCursor>`) - #160970 (Fix handling of relative paths starting with a dot in bootstrap)
rust-timer
added a commit
that referenced
this pull request
Aug 12, 2026
Rollup merge of #160952 - bushrat011899:write_for_cursor_stability_fix, r=clarfonthey Fix improper stability of `Write for Cursor<W: WriteThroughCursor>` Was already stable when using explicit types (e.g. `Vec<u8>`). `WriteThroughCursor` is still unstable/hidden. Tracking Issue: #154046 Zulip Discussion: [#general > ✔ CI Failure With and Without Stability Attribute](https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/.E2.9C.94.20CI.20Failure.20With.20and.20Without.20Stability.20Attribute/with/615974133) # Description Fixes an oversight in how the `Write for Cursor<W: WriteThroughCursor>` implementation was written. While `core::io` was unstable, a stability attribute for this implementation was not required. However, once that module is marked as stable (even when `Cursor` and `Write` are not publicly stably exported), a stability attribute is required. Since `Write` and `Cursor` are both stable items (just not stable to access via `core::io`), the implementation must be marked as stable. While it is possible to use [#[unstable_feature_bound(core_io)]](https://rustc-dev-guide.rust-lang.org/stability.html#unstable_feature_bound) to allow that implementation to be unstable, we do need users to have access to it stably, since it is how implementations such as `Write for Cursor<Vec<u8>>` are accessed. This is also why this implementation is marked as stable since `1.0.0`, since that is the earliest downstream implementation we must permit. --- ## Notes - No AI tooling of any kind was used during the creation of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was already stable when using explicit types (e.g.
Vec<u8>).WriteThroughCursoris still unstable/hidden.Tracking Issue: #154046
Zulip Discussion: #general > ✔ CI Failure With and Without Stability Attribute
Description
Fixes an oversight in how the
Write for Cursor<W: WriteThroughCursor>implementation was written. Whilecore::iowas unstable, a stability attribute for this implementation was not required. However, once that module is marked as stable (even whenCursorandWriteare not publicly stably exported), a stability attribute is required. SinceWriteandCursorare both stable items (just not stable to access viacore::io), the implementation must be marked as stable.While it is possible to use #[unstable_feature_bound(core_io)] to allow that implementation to be unstable, we do need users to have access to it stably, since it is how implementations such as
Write for Cursor<Vec<u8>>are accessed. This is also why this implementation is marked as stable since1.0.0, since that is the earliest downstream implementation we must permit.Notes