dogfood #[diagnostic::unknown] in the compiler - #160950
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
mejrs
changed the title
#[diagnostic::unknown] in the compiler#[diagnostic::unknown] in the compiler
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 13, 2026
Rollup of 5 pull requests Successful merges: - #160998 (rustfmt: restrict `cfg_select!` formatting to the `nightly` release channel) - #154150 (core: Improve the documentation for funnel shifts) - #161009 (Fix asimd/neon detection on aarch64-darwin) - #160950 (dogfood `#[diagnostic::unknown]` in the compiler) - #161010 (Add regression test for const fn returning Vec of boxed dyn Any)
rust-timer
added a commit
that referenced
this pull request
Aug 13, 2026
Rollup merge of #160950 - mejrs:unknown_symbol, r=chenyukang dogfood `#[diagnostic::unknown]` in the compiler This makes the error for not-found symbols a lot nicer :) ``` error[E0425]: cannot find value `better_rust` in module `sym` --> compiler\rustc_feature\src\unstable.rs:799:16 | 157 | name: sym::$feature, | -------- due to this macro variable ... 799 | (unstable, better_rust, "2.0.0", Some(42)), | ^^^^^^^^^^^ `better_rust` is not a pre-interned symbol | = note: consider adding `better_rust` to the `symbols!` invocation in compiler/rustc_span/src/symbol.rs ``` (only works when building stage 2 for now, the necessary changes haven't landed in beta yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the error for not-found symbols a lot nicer :)
(only works when building stage 2 for now, the necessary changes haven't landed in beta yet)