Inline some hot new-solver functions by nnethercote · Pull Request #160892 · rust-lang/rust

nnethercote · 2026-08-11T05:04:30Z

rerunning_stalled_goal_may_make_progress is split into always-inline and never-inline variants, because it's biggish and has multiple call sites but only one is hot. The other are easy, being either very small or having a single call site.

r? @jdonszelmann

nnethercote · 2026-08-11T05:04:44Z

@bors try @rust-timer queue

Inline some hot new-solver functions

rust-bors · 2026-08-11T06:03:26Z

☀️ Try build successful (CI)
Build commit: bdde1fb (bdde1fb32f7450db6fd5d778d69a117c761459ed)
Base parent: 0e72e32 (0e72e3266cdd2fe5a658aff454a778a88e5220a3)

rust-timer · 2026-08-11T06:45:04Z

Finished benchmarking commit (bdde1fb): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.8%, -0.4%]	6
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.7%	[0.5%, 1.0%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-1.5%, -0.4%]	12
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 454.011s -> 454.672s (0.15%)
Artifact size: 398.43 MiB -> 398.47 MiB (0.01%)

nnethercote · 2026-08-11T07:55:45Z

Interesting... no perf effect on CI, but I get big effects locally:

Presumably this is because CI has PGO and already inlines these functions based on profiling data.

I think it's worth merging this nonetheless, for two reasons:

Not every platform has PGO, so the non-PGO platforms will benefit from this.
People profiling locally won't be misled.

rustbot · 2026-08-11T07:55:51Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 17 candidates

rustbot · 2026-08-11T07:59:32Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

nnethercote · 2026-08-12T00:20:35Z

I rebased over #158436 and somehow things got even better locally:

nnethercote · 2026-08-12T00:21:20Z

Let's do another perf run just to check it's still a no-op with PGO enabled.

@bors try @rust-timer queue

Inline some hot new-solver functions

rust-bors · 2026-08-12T01:26:44Z

☀️ Try build successful (CI)
Build commit: 326d826 (326d826e4be272600a38d4309892f4631e3d5c6b)
Base parent: 3d6c19b (3d6c19bb9ab4798ecfb2ee943df01a811720fc27)

rust-timer · 2026-08-12T02:09:04Z

Finished benchmarking commit (326d826): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.0%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.8%	[-8.0%, -3.7%]	2
Improvements ✅ (secondary)	-2.4%	[-11.6%, -0.4%]	6
All ❌✅ (primary)	-3.0%	[-8.0%, 2.8%]	3

Cycles

Results (secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.7%	[0.4%, 1.1%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-1.1%, -0.5%]	8
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 455.92s -> 456.054s (0.03%)
Artifact size: 396.47 MiB -> 396.34 MiB (-0.03%)

nnethercote · 2026-08-12T02:37:00Z

Still neutral on CI, still worth landing IMO:

Not every platform has PGO, so the non-PGO platforms will benefit from this.

People profiling locally won't be misled.

`rerunning_stalled_goal_may_make_progress` is split into always-inline and never-inline variants, because it's biggish and has multiple call sites but only one is hot. The other are easy, being either very small or having a single call site.

rustbot · 2026-08-12T22:25:41Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2026-08-12T22:26:27Z

I rebased again. This is surprisingly conflict-prone for such a small PR. @jdonszelmann, if/when you get a chance... :)

jdonszelmann · 2026-08-14T06:32:54Z

@bors r+

Easy decision haha, especially num_opaque_entries should've been inline a long time ago

rust-bors · 2026-08-14T06:32:57Z

📌 Commit a5ff8f5 has been approved by jdonszelmann

It is now in the queue for this repository.

@jdonszelmann

…=jdonszelmann Inline some hot new-solver functions `rerunning_stalled_goal_may_make_progress` is split into always-inline and never-inline variants, because it's biggish and has multiple call sites but only one is hot. The other are easy, being either very small or having a single call site. r? @jdonszelmann

@jdonszelmann

…=jdonszelmann Inline some hot new-solver functions `rerunning_stalled_goal_may_make_progress` is split into always-inline and never-inline variants, because it's biggish and has multiple call sites but only one is hot. The other are easy, being either very small or having a single call site. r? @jdonszelmann

…uwer Rollup of 11 pull requests Successful merges: - #158510 (Enable `static_position_independent_executables` on all gnu targets) - #160441 (PowerPC inline ASM: Fix scalar floats being in the wrong vector lane on little endian) - #160760 (Miri: give the incremental session a chance to finish) - #160892 (Inline some hot new-solver functions) - #160821 (Updates the expect messages in library/std/src/net/udp.rs to follow the style guide) - #160997 (Add an AGENTS.md that enforces the LLM policy) - #161057 (Silence unecessary errors on `Vec<foo::Bar>` to `Vec<foo:Bar>` typo) - #161079 (bootstrap: Clean up imports related to `define_config!` and `check_ci_llvm!`) - #161080 (propagate `RerunNonErased` in `projection_may_match`) - #161085 (bootstrap: Restrict the normalization of relative paths) - #161086 (add crashtests [3/N])

@jdonszelmann

Rollup merge of #160892 - nnethercote:new-solver-inlining, r=jdonszelmann Inline some hot new-solver functions `rerunning_stalled_goal_may_make_progress` is split into always-inline and never-inline variants, because it's biggish and has multiple call sites but only one is hot. The other are easy, being either very small or having a single call site. r? @jdonszelmann

@jdonszelmann

Rollup merge of #160892 - nnethercote:new-solver-inlining, r=jdonszelmann Inline some hot new-solver functions `rerunning_stalled_goal_may_make_progress` is split into always-inline and never-inline variants, because it's biggish and has multiple call sites but only one is hot. The other are easy, being either very small or having a single call site. r? @jdonszelmann

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 11, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026

Auto merge of #160892 - nnethercote:new-solver-inlining, r=<try>

bdde1fb

Inline some hot new-solver functions

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 11, 2026

nnethercote marked this pull request as ready for review August 11, 2026 07:55

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2026

rustbot assigned fee1-dead Aug 11, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 11, 2026

rustbot assigned jdonszelmann and unassigned fee1-dead Aug 11, 2026

This comment has been minimized.

Sign in to view

nnethercote force-pushed the new-solver-inlining branch from 6e6c025 to 9fd82ee Compare August 12, 2026 00:17

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 12, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 12, 2026

Auto merge of #160892 - nnethercote:new-solver-inlining, r=<try>

326d826

Inline some hot new-solver functions

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 12, 2026

This comment has been minimized.

Sign in to view

Inline some hot new-solver functions

a5ff8f5

`rerunning_stalled_goal_may_make_progress` is split into always-inline and never-inline variants, because it's biggish and has multiple call sites but only one is hot. The other are easy, being either very small or having a single call site.

nnethercote force-pushed the new-solver-inlining branch from 9fd82ee to a5ff8f5 Compare August 12, 2026 22:25

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2026

JonathanBrouwer mentioned this pull request Aug 14, 2026

Rollup of 10 pull requests #161089

Closed

This was referenced Aug 14, 2026

Rollup of 11 pull requests #161092

Closed

Rollup of 11 pull requests #161093

Merged

rust-bors Bot merged commit 90046d0 into rust-lang:main Aug 14, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 14, 2026

Uh oh!

Uh oh!

Conversation

nnethercote commented Aug 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nnethercote commented Aug 11, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 11, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Aug 11, 2026

Overall result: no relevant changes - no action needed

Uh oh!

nnethercote commented Aug 11, 2026

Uh oh!

rustbot commented Aug 11, 2026

Uh oh!

rustbot commented Aug 11, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

nnethercote commented Aug 12, 2026

Uh oh!

nnethercote commented Aug 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 12, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Aug 12, 2026

Overall result: no relevant changes - no action needed

Uh oh!

nnethercote commented Aug 12, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 12, 2026

Uh oh!

nnethercote commented Aug 12, 2026

Uh oh!

jdonszelmann commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Aug 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nnethercote commented Aug 11, 2026 •

edited by rustbot

Loading

jdonszelmann commented Aug 14, 2026 •

edited

Loading