Fix autodiff_illegal.rs test - #160768
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
mejrs
reviewed
Aug 8, 2026
Contributor
There was a problem hiding this comment.
Looks like fallout of #160577
Is it correct to enable proc_macro_hygiene here rather than just change the test output? The test did not previously enable stmt_expr_attributes, for example.
Note also that proc_macro_hygiene is sort of a grab bag of things that macros can't be on and we're likely to move individual items to stable rather than stabilize the entire feature at once. As such if you want this test to reflect changes in what positions macros are allowed in it would be better to not enable the feature.
JonathanBrouwer
changed the title
proc_macro_hygiene feature gate to autodiff_illegal.rs to fix CI
JonathanBrouwer
force-pushed
the
fix_autodiff_ci
branch
from
August 8, 2026 20:40
1485070 to
acd2f65
Compare
Contributor
Author
|
@mejrs Agreed, fixed |
Contributor
Author
|
@bors try jobs=optional-x86_64-gnu-autodiff |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 8, 2026
Fix autodiff_illegal.rs test try-job: optional-x86_64-gnu-autodiff
mejrs
approved these changes
Aug 8, 2026
Contributor
Member
|
@bors r=mejrs,ZuseZ4 rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 9, 2026
…=mejrs,ZuseZ4 Fix autodiff_illegal.rs test This fixes the current CI failure: rust-lang#160761 (comment) r? @ZuseZ4
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
Rollup of 6 pull requests Successful merges: - #160529 (Upgrade and deduplicate dependencies) - #158517 (Initial implementation of named `Fn` trait parameters) - #158587 (check if len of array const arg matches the expected len of the type when lowering to valtree) - #160748 (Add regression test for cross-crate assoc const private field leak in rustdoc) - #160708 (remove old update mechanism) - #160768 (Fix autodiff_illegal.rs test)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
Rollup of 5 pull requests Successful merges: - #158517 (Initial implementation of named `Fn` trait parameters) - #158587 (check if len of array const arg matches the expected len of the type when lowering to valtree) - #160748 (Add regression test for cross-crate assoc const private field leak in rustdoc) - #160708 (remove old update mechanism) - #160768 (Fix autodiff_illegal.rs test)
rust-timer
added a commit
that referenced
this pull request
Aug 9, 2026
Rollup merge of #160768 - JonathanBrouwer:fix_autodiff_ci, r=mejrs,ZuseZ4 Fix autodiff_illegal.rs test This fixes the current CI failure: #160761 (comment) r? @ZuseZ4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the current CI failure: #160761 (comment)
r? @ZuseZ4