Enable -Znext-solver on nightly by default

[Kivooeo]

View all comments

this is a draft for now, i will update description once crater finishes

[Kivooeo]

@bors try

[Kivooeo]

@craterbot check

[craterbot]

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[Kivooeo]

@craterbot run mode=check-only

[craterbot]

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[rust-bors]

☀️ Try build successful (CI)
Build commit: 365ca06 (365ca069469fcb0f8f783505542469e44ab556b8)
Base parent: 8b798d4 (8b798d41cc5d215ef8d5424f61b6dc2575ac738b)

[theemathas]

@craterbot check

[craterbot]

👌 Experiment pr-160619 created and queued.
🤖 Automatically detected try build 365ca06
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[lcnr]

@craterbot cancel

[lcnr]

already have a crater run in #133502

[craterbot]

🗑️ Experiment pr-160619 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[Kivooeo]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: cc33267 (cc33267ec3bdc5624adccc77c0610515257e580b)
Base parent: f76a50b (f76a50bb82442dd7208c08a27e2ed258d1f10310)

[rust-timer]

Finished benchmarking commit (cc33267): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	13.4%	[0.3%, 219.8%]	252
Regressions ❌ (secondary)	8.3%	[0.1%, 101.3%]	262
Improvements ✅ (primary)	-5.8%	[-25.4%, -0.4%]	25
Improvements ✅ (secondary)	-9.0%	[-81.4%, -0.2%]	80
All ❌✅ (primary)	11.7%	[-25.4%, 219.8%]	277

Max RSS (memory usage)

Results (primary 5.8%, secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.8%	[0.8%, 35.5%]	153
Regressions ❌ (secondary)	3.5%	[0.4%, 7.8%]	65
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-3.0%	[-6.5%, -0.4%]	37
All ❌✅ (primary)	5.8%	[-1.9%, 35.5%]	154

Cycles

Results (primary 12.1%, secondary 4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	13.7%	[2.1%, 164.9%]	179
Regressions ❌ (secondary)	9.9%	[0.7%, 60.3%]	144
Improvements ✅ (primary)	-5.9%	[-16.8%, -1.9%]	16
Improvements ✅ (secondary)	-18.1%	[-79.2%, -1.4%]	33
All ❌✅ (primary)	12.1%	[-16.8%, 164.9%]	195

Binary size

Results (primary 0.2%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.4%]	40
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.0%, 0.4%]	40

Bootstrap: 454.448s -> 465.436s (2.42%)
Artifact size: 396.47 MiB -> 394.85 MiB (-0.41%)