Skip to content

bootstrap: always build llvm's dylib when linking to it #160597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xSetech wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

bootstrap: always build llvm's dylib when linking to it #160597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/bootstrap/src/core/build_steps/llvm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,11 @@ impl CommandLineStep for Llvm {
// which saves both memory during parallel links and overall disk space
// for the tools. We don't do this on every platform as it doesn't work
// equally well everywhere.
if builder.llvm_link_shared() {
cfg.define("LLVM_LINK_LLVM_DYLIB", "ON");
// Keep the pre-LLVM23 behavior for now.
cfg.define("LLVM_VERSIONED_DYLIB_NAME_ON_DARWIN", "OFF");
}
let llvm_link_shared = if builder.llvm_link_shared() { "ON" } else { "OFF" };
cfg.define("LLVM_LINK_LLVM_DYLIB", llvm_link_shared);
cfg.define("LLVM_BUILD_LLVM_DYLIB", llvm_link_shared);
// Keep the pre-LLVM23 behavior for now.
cfg.define("LLVM_VERSIONED_DYLIB_NAME_ON_DARWIN", "OFF");

if (target.starts_with("csky")
|| target.starts_with("riscv")
Expand Down
Loading