Skip to content

diagnostics: Suggest fn binding type for unstable closure for<> binders #160478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dnreikronos wants to merge 2 commits into
base: main
Choose a base branch
from
Open

diagnostics: Suggest fn binding type for unstable closure for<> binders #160478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da0f869
Suggest moving for<> closure binders onto fn binding types
Dnreikronos Aug 4, 2026
1fccd4c
Add UI coverage for closure for<> binder binding suggestions
Dnreikronos Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions compiler/rustc_ast_passes/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,3 +1257,35 @@ pub(crate) struct VarargsWithoutPattern {
#[primary_span]
pub span: Span,
}

#[derive(Subdiagnostic)]
pub(crate) enum ClosureLifetimeBinderBindingTypeSugg {
#[multipart_suggestion(
"consider setting the binding type instead",
applicability = "machine-applicable",
style = "verbose"
)]
MachineApplicable {
#[suggestion_part(code = ": {ty}")]
binding: Span,
ty: String,
#[suggestion_part(code = "{closure}")]
closure_header: Span,
closure: String,
},
/// Used when the body references other simple paths: they may be captures (or free items).
/// Without name resolution we can't tell, so rustfix must not auto-apply.
#[multipart_suggestion(
"consider setting the binding type instead",
applicability = "maybe-incorrect",
style = "verbose"
)]
MaybeIncorrect {
#[suggestion_part(code = ": {ty}")]
binding: Span,
ty: String,
#[suggestion_part(code = "{closure}")]
closure_header: Span,
closure: String,
},
}
Loading
Loading