Rename symbols rather than add symbol aliases for EIIs when possible - #159843
Draft
bjorn3 wants to merge 6 commits into
Draft
Rename symbols rather than add symbol aliases for EIIs when possible#159843bjorn3 wants to merge 6 commits into
bjorn3 wants to merge 6 commits into
Conversation
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reduces the amount of special casing #[no_mangle] needs in the rest of the compiler.
#[link_ordinal] is not compatible with #[link_name] and items in extern blocks now have an implicit #[link_name] with the item name. Alternatively it would be possible to suppress the error message for this implicit #[link_name].
bjorn3
force-pushed
the
eii_using_symbol_rename
branch
from
August 4, 2026 12:54
0ad7e4b to
580bf28
Compare
The symbol name of the EII impl will now get changed to match the EII decl whenever there is no default impl. This already works across all backends and targets unlike the weak symbol aliases that we currently use. When there is a default impl, we will still use weak symbol aliases.
bjorn3
force-pushed
the
eii_using_symbol_rename
branch
from
August 4, 2026 13:43
580bf28 to
3b34082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbol name of the EII impl will now get changed to match the EII decl whenever there is no default impl. This already works across all backends and targets unlike the weak symbol aliases that we currently use. When there is a default impl, we will still use weak symbol aliases.
Based on #159374